Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kubelet config file into run directory #5305

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

twz123
Copy link
Member

@twz123 twz123 commented Nov 29, 2024

Description

This is generated at runtime and doesn't need to be part of the persistent data directory. Group private kubelet fields together, to have a better overview which fields are used by the external configuration versus the internal state. Rename dataDir to rootDir to reflect that it's the kubelet's root directory and not k0s's data directory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

To have a better overview which fields are used by the external
configuration versus the internal state. Also, rename dataDir to rootDir
to reflect that it's the kubelet's root directory and not k0s's data
directory.

Signed-off-by: Tom Wieczorek <[email protected]>
This is generated at runtime and doesn't need to be part of the
persistent data directory.

Signed-off-by: Tom Wieczorek <[email protected]>
@twz123 twz123 merged commit 3cdabc8 into k0sproject:main Dec 10, 2024
92 checks passed
@twz123 twz123 deleted the kubelet-config-in-run-dir branch December 10, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants